Skip to content

Define how SDK implements Logger.Enabled #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 23, 2025
Merged

Define how SDK implements Logger.Enabled #4381

merged 20 commits into from
Jan 23, 2025
+24 −1

Conversation

@pellared
Copy link
Member

@pellared pellared commented Jan 22, 2025 •
edited
Loading

@pellared pellared added the spec:logs Related to the specification/logs directory label Jan 22, 2025
@pellared pellared self-assigned this Jan 22, 2025
@pellared pellared changed the title Define SDK's Logger.Enabled Define how SDK implements Logger.Enabled Jan 22, 2025
@pellared pellared marked this pull request as ready for review January 22, 2025 15:44
@pellared pellared requested review from a team January 22, 2025 15:44
dashpole
dashpole reviewed Jan 22, 2025
View reviewed changes
@pellared pellared requested a review from dashpole January 22, 2025 16:46
cijothomas
cijothomas reviewed Jan 22, 2025
View reviewed changes
MrAlias
MrAlias reviewed Jan 22, 2025
View reviewed changes
MrAlias
MrAlias reviewed Jan 22, 2025
View reviewed changes
lalitb
lalitb approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

cijothomas
cijothomas reviewed Jan 22, 2025
View reviewed changes
@pellared pellared requested a review from cijothomas January 22, 2025 18:43
@jack-berg jack-berg mentioned this pull request Jan 22, 2025
Closed
pellared
pellared commented Jan 22, 2025
View reviewed changes
jack-berg
jack-berg approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think all of this is implied elsewhere (except the "there are no registered LogRecordProcessors" part), but good to be explicit. Should followup by doing the same with traces and metrics. Feel free to do that if you'd like, or simply open an issue to track the followup - I'm not trying to volunteer you for more work.

lmolkova
lmolkova approved these changes Jan 23, 2025
View reviewed changes
@pellared
Update specification/logs/noop.md
021973e 
Co-authored-by: Liudmila Molkova <[email protected]>
carlosalberto
carlosalberto reviewed Jan 23, 2025
View reviewed changes
@reyang reyang merged commit c55ed5c into open-telemetry:main Jan 23, 2025
6 checks passed
@pellared pellared deleted the sdk-logger-enabled branch January 23, 2025 23:19
@lmolkova lmolkova mentioned this pull request Feb 3, 2025
Open
This was referenced Feb 4, 2025
Closed
Open
@pellared
Copy link
Member Author

pellared commented Feb 4, 2025

Thanks for this. I think all of this is implied elsewhere (except the "there are no registered LogRecordProcessors" part), but good to be explicit. Should followup by doing the same with traces and metrics. Feel free to do that if you'd like, or simply open an issue to track the followup - I'm not trying to volunteer you for more work.

Issues creates:

@pellared pellared mentioned this pull request Feb 4, 2025
Closed
@carlosalberto carlosalberto mentioned this pull request Feb 10, 2025
Merged
carlosalberto added a commit that referenced this pull request Feb 18, 2025
@carlosalberto
Release 1.42.0 (#4410)
eb2f6ea 
February 2025 Release.

### Traces

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([#4368](#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([#4162](#4162))

### Logs

- Define how SDK implements `Logger.Enabled`.

([#4381](#4381))
- Logs API should have functionality for reusing Standard Attributes.

([#4373](#4373))

### SDK Configuration

- Define syntax for escaping declarative configuration environment
variable
  references.

([#4375](#4375))
- Resolve various declarative config TODOs.

([#4394](#4394))
cijothomas pushed a commit to cijothomas/opentelemetry-specification that referenced this pull request Feb 19, 2025
@carlosalberto @cijothomas
Release 1.42.0 (open-telemetry#4410)
cdc86be 
February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))
cijothomas pushed a commit to cijothomas/opentelemetry-specification that referenced this pull request Feb 19, 2025
@carlosalberto @cijothomas
Release 1.42.0 (open-telemetry#4410)
98c09d9 
February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))
@pellared pellared mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@lmolkova lmolkova lmolkova approved these changes

@dashpole dashpole dashpole approved these changes

@cijothomas cijothomas cijothomas approved these changes

@MrAlias MrAlias MrAlias approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

+1 more reviewer

@lalitb lalitb lalitb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pellared pellared

Labels

spec:logs Related to the specification/logs directory

Projects

Go: Logs (GA)
Status: Done
Logs SIG
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@pellared @carlosalberto @lalitb @lmolkova @dashpole @cijothomas @MrAlias @reyang @jack-berg